Fix Mac Whisper speech-to-text beep in terminal#28
Closed
dhilgaertner wants to merge 2 commits intomainfrom
Closed
Fix Mac Whisper speech-to-text beep in terminal#28dhilgaertner wants to merge 2 commits intomainfrom
dhilgaertner wants to merge 2 commits intomainfrom
Conversation
e51d7db to
ce35e5a
Compare
Collaborator
|
Just tried this out, and it hasn't improved anything. |
…xt (#25) Add doCommand(by:) override to GhosttySurfaceView to prevent NSBeep when interpretKeyEvents dispatches unhandled selectors (noop:, cancel:, etc.). This also satisfies the NSTextInputClient protocol requirement, enabling external text injection tools like Mac Whisper to work properly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ce35e5a to
971d365
Compare
Collaborator
|
Just tried it again, same problem. |
Collaborator
|
resolved by #25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doCommand(by:)override toGhosttySurfaceViewto prevent NSBeep wheninterpretKeyEventsdispatches unhandled selectors (e.g.noop:,cancel:)NSTextInputClientprotocol requirement for command handling, enabling external text injection tools like Mac Whisper to work without producing error soundsCloses #25
Test plan
🤖 Generated with Claude Code